I was referring mainly to her inclination to turn on the love switch on you anyway despite being told noejoslin wrote...
The thing is, she IS supposed to be different when hardened -- keep her unhardened, you get all the same dialogs as the vanilla game. But it's an obvious bug keeping the hardened dialogs out. The character was written this way.
Wasn't aware of the issues with hardened versions of the conversations, but then i left her the default way in the playthroughs so far.
tmp7704 wrote...
I was referring mainly to her inclination to turn on the love switch on you anyway despite being told noejoslin wrote...
The thing is, she IS supposed to be different when hardened -- keep her unhardened, you get all the same dialogs as the vanilla game. But it's an obvious bug keeping the hardened dialogs out. The character was written this way.
Modifié par ejoslin, 22 juin 2010 - 04:04 .
Yes, sadly.ejoslin wrote...
I've fixed quite a few of her bugs. I think I have all the hardened/unhardened ones, the loop in her conversation, her not being in a romance when asking about the marriage, then there's this one. Also, I just fixed (will go in my newest version) an incorrect dialog choice appearing if the romance is cut off. Are there more?
Modifié par blademaster7, 22 juin 2010 - 04:11 .
Modifié par Master Shiori, 22 juin 2010 - 04:15 .
Hmm actually, that LELIANA_MAIN_CHANGED doesn't have any code attached to it is pretty normal -- it is a "main flag", that is the type of switch which gets set/read by dialogue files and possibly scripts, but it's not evaluated every time it is accessed, hence no code is necessary for it (it can be present if setting the flag triggers some additional events like completion of a quest or a cutscene but otherwise it's not required) Only the "defined flags" need to have the code attached to them because it's that code that calculates the state of switch dynamically each time the flag is tested.ejoslin wrote...
Ahhhh, no. I'm leaving a lot of stuff alone. I do my fixes based off script notes and very obvious bugs. The hardened dialog isn't getting in because a flag is used that doesn't have any code attached to it -- it's easy enough to switch the flags (easier than fixing the flag since I avoid changing the .ncs files whenever possible.
blademaster7 wrote...
Yes, sadly.ejoslin wrote...
I've fixed quite a few of her bugs. I think I have all the hardened/unhardened ones, the loop in her conversation, her not being in a romance when asking about the marriage, then there's this one. Also, I just fixed (will go in my newest version) an incorrect dialog choice appearing if the romance is cut off. Are there more?
I don't have the toolset open so these are the ones I remember for now.
1.If ther romance is active and she's hardened she will join the threesome at the pearl. The scripting comments in the toolset suggest that she will only join if she is adore or higher. However, the adore flag is missing which means you can get her into the threesome with a very low appoval. If you ask me I would rather have the make_love flag set to true in order for her to join (basically, the same with Alistair).
2. Her dialogue when you ask her if she feels better about what happened with Marjie(you know the one that goes ninja on you) is supposed to be different for each gender. You only hear the female version in vanilla.
3. "Does the hero get his girl" at the coronation for males. This line should only be available if the romance is active. That's what the scripting comments suggest(as if it wasn't obvious already). It appears for everyone.
tmp7704 wrote...
Hmm actually, that LELIANA_MAIN_CHANGED doesn't have any code attached to it is pretty normal -- it is a "main flag", that is the type of switch which gets set/read by dialogue files and possibly scripts, but it's not evaluated every time it is accessed, hence no code is necessary for it (it can be present if setting the flag triggers some additional events like completion of a quest or a cutscene but otherwise it's not required) Only the "defined flags" need to have the code attached to them because it's that code that calculates the state of switch dynamically each time the flag is tested.ejoslin wrote...
Ahhhh, no. I'm leaving a lot of stuff alone. I do my fixes based off script notes and very obvious bugs. The hardened dialog isn't getting in because a flag is used that doesn't have any code attached to it -- it's easy enough to switch the flags (easier than fixing the flag since I avoid changing the .ncs files whenever possible.
Unless by no code you mean the game mistakenly sets the APP_LELIANA_CHANGED but then tests for LELIANA_MAIN_CHANGED?
Modifié par ejoslin, 22 juin 2010 - 04:28 .
Looking in the Toolset i don't see anything to this effect -- there's simply a check for APP_IS_CHANGED flag. If it's set Leliana will declare she can't let PC go alone, otherwise she'll protest and Isabela calls it off.blademaster7 wrote...
1.If ther romance is active and she's hardened she will join the threesome at the pearl. The scripting comments in the toolset suggest that she will only join if she is adore or higher. However, the adore flag is missing which means you can get her into the threesome with a very low appoval.
Modifié par tmp7704, 22 juin 2010 - 04:32 .
Modifié par ejoslin, 22 juin 2010 - 04:35 .
Me, too. They're only toons but I can't stand the thought of hours of snarky comments. And from an rpg perspective it is dubious, even if playing an "evil" pc. You could well end up lying unconscious on the field of battle and need these folks to save you.Giggles_Manically wrote...
I never push people into even the negative approval region. I find it pretty easy to get along with everyone on most things.
Modifié par blademaster7, 22 juin 2010 - 04:43 .
Ahh indeed, it doesn't show in the line itself so i overlooked that.ejoslin wrote...
You are missing something. The script note says she should be at adore or higher. It's where Leliana says, "You're going with her?"
Alistair does have the "adore or higher" check actually. It's on Isabela's line "Perhaps your friend is feeling left out?" which opens option to coax him into the whole deal. Without it he just goes to stand in corner, sulking.blademaster7 wrote...
If you want my opinion the I suggest using then "make_love" flag and not the adore one. That's how it works for Alistair and Morrigan(well, she won't join but she will start yelling at you lol).
Modifié par tmp7704, 22 juin 2010 - 04:49 .
Nah... Leliana won't sleep with you unless you get her approval at 91+(love). To have her join a threesome(or even foursome) when her approval is in the 50ish zone seems wrong to me.tmp7704 wrote...
Ahh indeed, it doesn't show in the line itself so i overlooked that.ejoslin wrote...
You are missing something. The script note says she should be at adore or higher. It's where Leliana says, "You're going with her?"
Would presume the comment is just remains of something that was eventually changed to the current state, maybe because Leliana is supposed to be more open-minded about this sort of things than Alistair who does have this check implemented. But it's hard to tell.
tmp7704 wrote...
Ahh indeed, it doesn't show in the line itself so i overlooked that.ejoslin wrote...
You are missing something. The script note says she should be at adore or higher. It's where Leliana says, "You're going with her?"
Would presume the comment is just remains of something that was eventually changed to the current state, maybe because Leliana is supposed to be more open-minded about this sort of things than Alistair who does have this check implemented. But it's hard to tell.
I think it might work with her because the way her line is worded puts it in context she's doing that out of jealousy someone else will get it on exclusively if she doesn't interfere, and that's pretty strong incentive to do something she otherwise wouldn't (yet) do. I could see the love thing reasoning work too, though.blademaster7 wrote...
Nah... Leliana won't sleep with you unless you get her approval at 91+(love). To have her join a threesome(or even foursome) when her approval is in the 50ish zone seems wrong to me.
That's why I recommended the make_love flag. You only get it after you bed Leliana(and her approval will be very high by that point).
He does? Seems superfluous when he also has the make_love flag.tmp7704 wrote...
Alistair does have the "adore or higher" check actually. It's on Isabela's line "Perhaps your friend is feeling left out?" which opens option to coax him into the whole deal. Without it he just goes to stand in corner, sulking.blademaster7 wrote...
If you want my opinion the I suggest using then "make_love" flag and not the adore one. That's how it works for Alistair and Morrigan(well, she won't join but she will start yelling at you lol).
edit: there's further condition for make_love too though down the line, yes.
blademaster7 wrote...
He does? Seems superfluous when he also has the make_love flag.tmp7704 wrote...
Alistair does have the "adore or higher" check actually. It's on Isabela's line "Perhaps your friend is feeling left out?" which opens option to coax him into the whole deal. Without it he just goes to stand in corner, sulking.blademaster7 wrote...
If you want my opinion the I suggest using then "make_love" flag and not the adore one. That's how it works for Alistair and Morrigan(well, she won't join but she will start yelling at you lol).
edit: there's further condition for make_love too though down the line, yes.
Hmmm... maybe both checks are needed just in case you slept with Alistair and then dropped his approval below 70? I don't know.
Modifié par ejoslin, 22 juin 2010 - 05:01 .
The adore check opens the conversation angle where the matter is brought up, the make_love is used to give player option to actually complete the deal.blademaster7 wrote...
He does? Seems superfluous when he also has the make_love flag.
Hmmm... maybe both checks are needed just in case you slept with Alistair and then dropped his approval below 70? I don't know.
Modifié par tmp7704, 22 juin 2010 - 05:01 .
Retour en haut