13 réponses à ce sujet

[Church0071]

Hi Everyone! 
 
I am VERY new to the wonderful world of scripting (as you will probably be able to tell from my question haha! ), in fact this is my first scrip that ISN’T about adding an item . The problem that I have is at some point AGES ago in game I chose a dialogue option (Asking about what changes when you become a Grey Warden -> “Just try that line on me” -> “Fine, keep them to yourself”) which permanently killed Alistair’s romance eligibility – aka no “You look handsome ” etc. initiators and NO WAY to start the romance as by this time in game I have already used up any romance-initiating specific conversations such as the Chantry one etc. I re-loaded that save and tested before and after it with and without using that particular dialogue and I am sure THAT “Fine, keep them to yourself” LINE was the one to cut off the romance eligibility. Anyhow, I am now trying to rectify this problem by adding a script . I have the following one:
 {

string sVar = GetLocalString(GetModule(),"RUNSCRIPT_VAR");

int nFind = FindSubString(sVar," ");

string sArea = SubString(sVar,0,nFind);



//DEBUG_PrintToScreen("Adding " + sXp + " XP to " + ToString(OBJECT_SELF));

//RewardXPParty(nXp, 5, OBJECT_SELF, OBJECT_SELF);

Approval_SetLoveEligible(APP_FOLLOWER_ALISTAIR,TRUE);

Approval_SetFriendlyEligible(APP_FOLLOWER_ALISTAIR,TRUE);

Approval_ChangeApproval(APP_FOLLOWER_ALISTAIR, 100);

Approval_SetRomanceActive(APP_FOLLOWER_ALISTAIR,TRUE);

WR_SetPlotFlag(PLT_GENPT_APP_ALISTAIR, APP_ALISTAIR_ROMANCE_ACTIVE, TRUE, TRUE);

WR_SetPlotFlag(PLT_GENPT_APP_ALISTAIR, APP_ALISTAIR_MAKE_LOVE, TRUE, TRUE);



if(Approval_IsRangeValid(APP_FOLLOWER_ALISTAIR, APP_ROMANCE_RANGE_LOVE, TRUE))

DisplayFloatyMessage(GetHero(), "wot", FLOATY_MESSAGE, 16777215, 20.0);



DisplayFloatyMessage(GetHero(), "WORKS", FLOATY_MESSAGE, 16777215, 20.0);

}



BUT this is for activating the romance straight up. What I want to do is NOT activate the Romance itself BUT activate the Romance Eligibility aka “LoveEligible” so that Alistair is friendly  but there is the OPTION to romance him (which seems to be impossible using console commands ). SO as far as I know the script is correct up until “Approval_SetRomanceActive(APP_FOLLOWER_ALISTAIR,TRUE);”. Will everything still work if I just change the “TRUE” to a “FALSE” for that one? ALSO What do I do about the rest of the script because I am really confused by the bits below that line.
 
Thanks for your time and any help is GREATLY (OH MY GOSH SO MUCH lol) appreciated lol!

[_L_o_B_o_]

I don't know how the romance logic works, but here is an idea... Maybe it is triggered by the approval value. So, since you are setting it to 100 (which I suppose is the maximun value), then it is activated inmediately. Try to set it to 0.

[Church0071]

Thanks for the suggestion L_o_B_o_  Unfortunately I tried this already (probably should have mentioned that lol  D’oh!) and no matter what the disposition score is the romance eligibility is still off. So it must be an independant factor . SO I guess my question now is: How can I change this script so that it turns on the romance eligibility but DOESN’T activate the romance? I really have no idea!  But thanks for the help so far

[_L_o_B_o_]

Have you tried to remove this line:



WR_SetPlotFlag(PLT_GENPT_APP_ALISTAIR, APP_ALISTAIR_MAKE_LOVE, TRUE, TRUE);



????

[Church0071]

Yes, I tried taking out all lines referencing Alistair love or activating the romance . So now the script looks like this:
 
 {

string sVar = GetLocalString(GetModule(),"RUNSCRIPT_VAR");

int nFind = FindSubString(sVar," ");

string sArea = SubString(sVar,0,nFind);



//DEBUG_PrintToScreen("Adding " + sXp + " XP to " + ToString(OBJECT_SELF));

//RewardXPParty(nXp, 5, OBJECT_SELF, OBJECT_SELF);

Approval_SetLoveEligible(APP_FOLLOWER_ALISTAIR,TRUE);

Approval_SetFriendlyEligible(APP_FOLLOWER_ALISTAIR,TRUE);

Approval_ChangeApproval(APP_FOLLOWER_ALISTAIR, 100);


}
 
BUT  I’m having trouble making it compile as I’m getting an error that whatever I name the script (In this case AlistairEligible) is an “Invalid Declaration Type”  so the compile fails. Maybe I’m doing something wrong in the setting up? All I did was open the Toolset go to File -> Manage Modules and set it to Single Player. Then I chose File -> New -> Script and named my script – leaving all of the sections below at default. Am I making some n00by mistake here, perhaps?  Ack!

[Church0071]

Whoops!  Double Post! Sorry!

Modifié par Church0071, 02 septembre 2010 - 01:23 .

[_L_o_B_o_]

Could you post the whole script (with includes and all)?

In Manage Modules, have you created a new module or have you opened the existing Single Player campaign? I think the cleanest way to run you script is as an addon to the Single Player, so you should create a new module and select Single Player as extended module.

Modifié par _L_o_B_o_, 02 septembre 2010 - 11:32 .

[Church0071]

“Includes”? I don’t understand  (Sorry, my English is not so great! ). If you mean the whole script, that’s in the first post. Is that not complete?  Ah, I was just using the Single Player Campaign! I’ll try making an addon module now. Fingers crossed!

[Church0071]

Ack!  It is still saying that whatever I name the resource is an “Invalid Declaration Type” whenever I try and save the script. Here is what I did to make my new module (I am going by this tutorial for the first part about making a new module, the rest is about making items so it's a bit irrelevant  - http://dragonagemodd...player-an-item/):
I went to File -> Manage Modules -> New. In the “Module Properties” window I named my module, gave it a UID (unique identifier) and then set the “Extended Module” as “Single Player”. I then opened my new module and in “Hierarchy” I selected “Single Player”. Next, I selected File-> New -> Script. I named my new resource the same thing as my module, like in the tutorial (so that shouldn’t be causing a problem ), and then I changed the “Module” to “Core Game Resources” (this is what was done in the tutorial…but that’s for making a weapon so…I’m not sure… ?) and the “Owner Module” to my new module. I then put my script in and tried to save and...the rest is history!
I hope that all makes sense and wasn't TOO boring  lol. HEY, if you know any good “How to create a new script” type of tutorials that would probably also help . I have looked but I can’t seem to find any for just making a basic bit of script!

Modifié par Church0071, 02 septembre 2010 - 01:38 .

[_L_o_B_o_]

Sorry, my English is not so great!

Mine is even worse. Elementary english I learned at school and watching tv shows xD

Here is the most basic script that will compile without errors (it does nothing):

The main function is where the script starts execution.

void main()
{
}

If you don't have any good reason to keep those 3 first lines of your script, I would remove them.

So, at first glance, your script would look like this:

void main()
{
   Approval_SetLoveEligible(APP_FOLLOWER_ALISTAIR,TRUE);
   Approval_SetFriendlyEligible(APP_FOLLOWER_ALISTAIR,TRUE);
   Approval_ChangeApproval(APP_FOLLOWER_ALISTAIR, 100);
}

But here you are using some functions and constants that have not been declared before. What's the value of APP_FOLLOWER_ALISTAIR? Where is the definition of the Approval_SetLoveEligible() function? That's why you use "includes". Those constants and functions are defined in another script: approval_h. So, you just have to include that file at the beginning of your script.

#include "approval_h"

void main()
{
   Approval_SetLoveEligible(APP_FOLLOWER_ALISTAIR,TRUE);
   Approval_SetFriendlyEligible(APP_FOLLOWER_ALISTAIR,TRUE);
   Approval_ChangeApproval(APP_FOLLOWER_ALISTAIR, 100);
}

This should compile correctly.

HEY, if you know any good “How to create a new script” type of tutorials that would probably also help

I think the wiki is the first place you should check for this kind of help.

Modifié par _L_o_B_o_, 02 septembre 2010 - 05:47 .

[Church0071]

Haha! I’m learning English by watching TV too!  It might not be the BEST way but it sure is the most fun.
Thank you SO MUCH for all of your help with the script  (and sorry for not replying for a few days – I was away with my family and the hotel had NO internet connection!!  I nearly died lol) The script compiled perfectly and I ran it in in game and got Alistair’s approval to 100 instantly so I knew it worked BUT there was still no romance option . Then I started reading through the wiki and I found out that the line:

Approval_SetLoveEligible(APP_FOLLOWER_ALISTAIR,TRUE);
ISN’T actually what makes the romance eligible  (that line is used for if you are ALREADY in a romance and want to make it possible to go from Adore to Love without doing his personal quest – which is what is normally the trigger for this transition). SO I decided to have a look at the Conversations section in the toolset and I found that the line I chose which seemed to end all romance options triggers this Action:

Plot: genpt_app_ alistair

Flag: APP_ALISTAIR_ROMANCE_CUT_OFF
It seems that THIS line is responsible for stopping the romance , so I tried to find it in scripting Functions (where I found Approval_SetFriendlyEligible ect.) in order to set it to FALSE but I had no luck until I looked under constants and found the line APP_ALISTAIR_ROMANCE_CUT_OFF.

Now my problem is that I don’t know how to set it (a Constant) to false without causing errors and I can’t find anything on the wiki dealing with this sort of thing .

P.S I am incredibly grateful for all of your help!!
P.P.S Your English seems fine to me!

Modifié par Church0071, 05 septembre 2010 - 03:21 .

[_L_o_B_o_]

You cannot change the value of a constant. That's why they are called "constants". But, APP_ALISTAIR_ROMANCE_CUT_OFF stores the name of a flag, not its value (TRUE or FALSE). What you need to do here is change the value of the flag.

To do so use the WR_SetPlotFlag() function:

WR_SetPlotFlag(PLT_GENPT_APP_ALISTAIR, APP_ALISTAIR_ROMANCE_CUT_OFF, FALSE);

Don't forget to add the following includes at the beginning:

#include "wrappers_h"
#include "plt_genpt_app_alistair"

Modifié par _L_o_B_o_, 05 septembre 2010 - 10:08 .

[Church0071]

Thank you SO MUCH!  It worked perfectly! You have NO IDEA how frustratingly close I got to your script after working on it for a while by myself lol!  I guess maybe this means I'm becoming slightly less n00by at scripting after all. I really couldn't have done it without your help, though! So thanks thanks thanks thanks thanks thanks and thanks again!!!

[_L_o_B_o_]

It is good to know that you tried it by yourself... It is usually more frustrating and takes more time, but you learn a lot of things by the way. That's the spirit! xD