9 réponses à ce sujet

[Artfoundry]

Hi
I'm trying to get a conversation to automatically start with NPC 2 after the death of NPC 1 (in a fight with the PC), but nothing's happening.

I added this code to the default OnDeath script for NPC 1 (saved a new version so I didn't overwrite the original and changed the script setting in the NPC properties):

    object oNPC = StringToObject("n_stepmother");
    object oPC = GetFirstPC();
    object oCale = StringToObject("c_human_cale");
    
    if (GetIsObjectValid(oNPC)) //if NPC2 is still alive
        if (GetFactionAverageReputation(oNPC, oPC) > 0) //and she's still friendly
        {
            ActionStartConversation(oCale, "conversation_cale_finloralive", FALSE, FALSE, FALSE, FALSE);
        }
    else
    {    
        ActionStartConversation(oCale, "conversation_cale_niledead", FALSE, FALSE, FALSE, FALSE);
    }

Is the 2nd if statement wrong?  Or do I need to do something else with this script - is simply adding this code in there not a good way of doing it?

[Kaldor Silverwand]

You can't use stringtoobject to get an object. Use GetNearestObjectByTag.



Regards

[Artfoundry]

ahh ok, thanks. I thought I'd used that before successfully... but maybe not.

[Artfoundry]

It's still not working. I think it may be the ActionStartConversation line, because I tried substituting that function for BeginConversation, and that partially worked - it made the NPC shout the first line of the conv. as if it was a one-liner (though it's not - it has one line followed by an End Dialog node).

[Artfoundry]

i've seen that before - what's the difference between using AssignCommand and just using the command directly?

I tried it, but it still doesn't work.  Here's the new script:

    object oPC = GetFirstPC();
    object oNPC = GetNearestObjectByTag("n_stepmother", oPC, 1);
    object oCale = GetNearestObjectByTag("c_human_cale", oPC, 1);
    
    if (GetIsObjectValid(oNPC)) //if Lorvinda is still alive
        if (GetFactionAverageReputation(oNPC, oPC) > 0)   //and she's still friendly
        {
            AssignCommand(oCale, ClearAllActions(TRUE));
            AssignCommand(oCale, ActionStartConversation(oCale, "conversation_cale_finloralive", FALSE, FALSE, FALSE, FALSE));
        }
    else
    {    
        AssignCommand(oCale, ClearAllActions(TRUE));
        AssignCommand(oCale, ActionStartConversation(oCale, "conversation_cale_niledead", FALSE, FALSE, FALSE, FALSE));
    }

Modifié par Artfoundry, 05 février 2011 - 06:09 .

[MasterChanger]

Artfoundry wrote...

i've seen that before - what's the difference between using AssignCommand and just using the command directly?

If you don't use AssignCommand, the command assumes that you want OBJECT_SELF to perform it. Depending what fires the script, this may or may not be what you want in this case.

    if (GetIsObjectValid(oNPC)) //if Lorvinda is still alive

Although GetIsObjectValid is generally a good function to call, you may also want to check !GetIsDead(oNPC) as well.

[Shaughn78]

Depending on the death system you are using and if you have companions you may also want to put a check to make sure the player has at least 1 hitpoint and raise and heal them if needed,



Just another small thing, with death scripts don't replace the default script. The default script will check a string on the object "DeathScript" and if you write the name of your death script there it will fire that script inaddition to the default.

[Kaldor Silverwand]

You have a mix of using braces and not using braces. I suggest you be consistent and always use them. Also you have it set to care about the starting distance. I would set that to TRUE so that starting distance is ignored. Try this. If it doesn't work, it at least improves readability.

void main()
{
    object oPC = GetFirstPC();
    object oNPC = GetNearestObjectByTag("n_stepmother", oPC, 1);
    object oCale = GetNearestObjectByTag("c_human_cale", oPC, 1);

    if (GetIsObjectValid(oNPC)) //if Lorvinda is still alive
    {
        if (GetFactionAverageReputation(oNPC, oPC) > 0)   //and she's still friendly
        {
            AssignCommand(oCale, ClearAllActions(TRUE));
            AssignCommand(oCale, ActionStartConversation(oCale, "conversation_cale_finloralive", FALSE, FALSE, TRUE, FALSE));
        }
   }
   else // Lorvinda is dead
   {    
        AssignCommand(oCale, ClearAllActions(TRUE));
        AssignCommand(oCale, ActionStartConversation(oCale, "conversation_cale_niledead", FALSE, FALSE, TRUE, FALSE));
    }
}

Modifié par Kaldor Silverwand, 05 février 2011 - 06:03 .

[Artfoundry]

Ok, I got it working - I had forgotten to set oPC as the target for ActionStartConversation. Heh, so basically I was telling Cale to have a conversation with himself.