17 réponses à ce sujet

[Shallina]

What have you done wrong ? hahahaah !!!! Everything !!!!! Just kidding.

void main()
{
object oPC=GetFirstPC(); /* oPC is used nowhere in this script, that ligne is useless if the full script is nothing more than this.*/

int nDeadTrolls = GetGlobalInt("dead_trolls");
nDeadTrolls ++;
//here what you are missing

SetGlobalInt("dead_trolls",nDeadTrolls); /* without this ligne the global int will never evolve nDeadTrolls is destroyed at the end ofg the script, when the script is loaded again it will be at the init value.*/

}
Well instead of all of this you can just use :

void main(){

SetGlobalInt("dead_trolls",GetGlobalInt("dead_trolls")+1);
}


and an other thing you can write
nDeadTrolls =+1;

that mean nDeadTroll will always be at +1.

But i think what you want is :

nDeadTrolls =nDeadTrolls+1;

wich can be writed
nDeadTrolls ++;
or
++nDeadTrolls ;

now having ++ before or after doesn't do the same thing.



void main{
int n = 1;

//teaching :
int x1 = n++;   //this mean x1 value is 1 but n value moved to 2
x1 = ++n;   //this mean x1 value is 2 and n value moved to 2

//pratical :

x2 = n++; //n is at 1 x2 is set at 1, and n is moved to 2.
x2 =++n; // n was at 2 and is moved to 3, and x2 is set at 3

}

Modifié par Shallina, 27 janvier 2012 - 12:28 .

[Lugaid of the Red Stripes]

The really fancy coders, when they're not admonishing you about the horrid indecency of using GetFirstPC(), will also warn you to avoid using global variables. The problem is that if you want to do this kind of code again in the same module, there might be some conflict with using the same variable over again. You could either think of a more specific name for the variable (i.e. "iQuestTrollSlayer_numDeadTrolls", or set the variable on another object, like the area or an i-point that you can access by tag. If there's a known and limited number of trolls to kill, you might even stick the variable into the quest journal, like where quest states 10-20 correspond to 0 to 10 dead trolls.

[Shallina]

GlobalInt is accross the whole campaign.

If your action happen only in a single area, the best is to store the number in the area

SetLocalInt(GetArea(OBJECT_SELF),"nameVar","value");

if your count is accross many area use the module :

SetLocalInt(GetModule(),"nameVar","value");

And to finish is the count is across many module, use GlobalInt.

CampaignInt exist but they aren't impacted  by save game.

Wich mean if you save, and reload later, the value of the campaign int won"t be reloaded at its previous value.

Good luck out there, you'll need it .

Modifié par Shallina, 27 janvier 2012 - 12:41 .

[The Fred]

I am not a sensible coder, but I trust myself to be smart enough not to do something stupid. As such, I don't care about things like global ints because if you are careful they will work fine. However, if you only need this variable locally, it's better to store it as a local, perhaps on the area in question. What if you want to count the number of trolls killed in another area later?

I should note a very minor point about what Shallina wrote, this:
nDeadTrolls = +1;
if perfectly valid, but does indeed simply set nDeadTrolls to 1. However, instead of writing:
nDeadTrolls = nDeadTrolls +1;
you can just write:
nDeadTrolls += 1;
which is I think what you were trying to do in the first place. However, when you're adding only one, it is better to write:
nDeadTrolls++;
because it's less typing. But then, that's C for you.

[Shallina]

SetGlobalInt("dead_trolls",GetGlobalInt("dead_trolls")+1);

use this. Your code can't work BTW beceause you set nothing new.

Modifié par Shallina, 27 janvier 2012 - 03:43 .

[Shallina]

int nDeadTrolls=SetGlobalInt("dead_trolls",GetGlobalInt("dead_trolls"));

I think this isn't even compiling.

SetGlobalInt can only return TRUE of FALSE if it return something.

Set store a value.

Get Fetch a value.

In your case you want to update an existing value and increase it by 1.

So First you need to get that value.

int nDeadTrolls = GetGlobal Int("dead_trolls");

Then you need to increase that value :

nDeadTrolls = nDeadTrolls+1;

Then you need to store that new value or else it will be lost at the end of the script.

SetGlobalInt("dead_trolls",nDeadTrolls);


Given the trouble you have to write this, there are probably problems in the way you check it in the conversation as well.

You need a gc_ script that check the number of dead troll in the condition panel (green one). Post it as well.

[Shallina]

this script work, it increase the dead_trolls count each time the script is called.

Wich mean now the problems is somewhere else :

Is the script called ?
and if the script is correctly called, is the dead_troll value correctly checked in the gc_script.

Now that you learned the basic of scripting, it's time for you to learn the basic of debugging "evil laught"

void main();
{
int nDeadTrolls = GetGlobalInt("dead_trolls");
nDeadTrolls =nDeadTrolls+1;
SetGlobalInt("dead_trolls",nDeadTrolls):
SendMessageToPC(GetFirstPC(FALSE),"I have killed "+ IntToString(GetGlobalInt("dead_trolls"))+ " trolls");
}

Each time you kill a troll you should have a message.
You should post your Gc script just in case, and I also could give you a line for debugging for it.

int StartingConditional(){

SendMessageToPC(GetFirstPC(FALSE), IntToString(GetGlobalInt("dead_trolls"))+ " trolls are dead");

if (GetGlobalInt("dead_trolls")==5){
return TRUE;
}
return FALSE;

}

Modifié par Shallina, 27 janvier 2012 - 04:44 .

[M. Rieder]

One last suggestion....

Instead of replacing the standard death script, you just have to store a local string on the creature and name it "DeathScript". The value of the string should be the name of the script you want to fire on the creature's death. This allows you to keep all the functionality of the standard on-death script and insert your own custom code.

[kevL]

Think of a script as a small short story. It has subjects and predicates, clauses and a plot sequence:

- subjects are like objects, ints, strings, etc.
- predicates (verbs) tell the game to do things to subjects.
- clauses are things like if(), while(), & for() 'scopes'.
- the plot sequence can be, and is altered by functions like DelayCommand(), AssignCommand(), ActionDoCommand(). aka The Epilogue (these happen only after the script completes)


hth