95 réponses à ce sujet

[Shadooow]

RE: stack overflow, that happens when you call some core function with incorrect (less or more) number of parameters. This can happen when you update module onto new patch but do not recompile all scripts. The script in question probably fails to compile because the certain function is missing a parameter and thus remains in its old state. You should be able to compile all your non-include scripts without error. Otherwise this is what might happen.

[BortSonofBort]

RE: stack overflow, that happens when you call some core function with incorrect (less or more) number of parameters. This can happen when you update module onto new patch but do not recompile all scripts. The script in question probably fails to compile because the certain function is missing a parameter and thus remains in its old state. You should be able to compile all your non-include scripts without error. Otherwise this is what might happen.

 

Great to know. Thank you, Shadooow!

[MagicalMaster]

Again, THANK YOU so much, MagicalMaster for your feedback. If you happen to consider anything else, or would even like to followup on some of my replies to your feedback, please feel free to send it my way.

 

Um, most of it boils down to "We'll see in the next build," but...

 

Bort - Yeah. I'm an oldish school video game RPGer. I've played videogames since the Intellivision, as many of us have, but one of my favorite games was from the 16-bit Genesis days. Shining Force is a favorite of mine. I say all of this to mention that certain elements of 'looting' not being challenged by the in-game world is something I'm willing to accept right now. Even in 2002 when NWN game came out, I remember module makers creating elaborate 'Jail' systems and whatnot. They were interesting systems, but something I was never interested to put into SVW. Maybe some day. As it is, looting is encouraged in this world, for sure.

 

I would just try to make a note of that as I expect many people would AVOID looting stuff out of principle -- they don't want to just steal from the orchid owner, for example.  Or even make an NPC say "You're helping the village out?  Take anything you need."  It's mainly a problem since it seems to be assumed that the player will loot that sort of stuff so players who DON'T are at a major disadvantage.

 

Hell, I only looted it to test it since this is beta feedback.

 

Bort - She is indeed weaker. Where Lynn can help heal you, use her turn undead spell, and use various ranged weapons, she faces the problem of being fragile. Drumble is the tank. The purpose for these contrasting opening-level henchmen is to support balancing off the character you decide to create on entry of the module. I tried to use their opening narrative when you meet either henchmen at the beginning as an opportunity to clue the player into how they would best assist a specific PC type.

 

Oh, I got the general idea, I just liked Lynn's personality better and figured as a cleric she'd still be reasonable in a fight.

 

I think the biggest problem is that there is really *zero* reason to pick Lynn, mechanics-wise.  Yes, she has slight healing, but the fighter is going to butcher stuff and you have plenty of healing anyway.  Would rather have a second fighter AS a fighter.  Going to save more on healing costs by just killing stuff faster than she'd ever make up.

 

If you swapped her to something like 14 strength starting and let her wear some armor she'd still be WEAKER than the fighter but it's now "better offense versus minor healing" (she likes to use Turn Undead versus single undead...doesn't really help when you're facing 50 of them and she has six uses).

 

Bort - Again, I've never experienced her not using her turn undead if rested. I'll have to look into this.

 

If she's in melee range with the enemy (since I lured a bunch together) she won't use it.  If she's at range she will.

 

Bort - Did you try selling the weapons at the weapon rack? Or did you try selling the weapons at the armor rack? Regarding Lynn not equipping better armor. I've have to look into that.

 

Yes, I could sell crossbows but not the melee weapons at the weapon rack.

 

I never actually gave Lynn better armor since her option is to adjust everything BUT her armor so I figured she WOULDN'T equip it.

 

Honestly, I think you might be better off biting the bullet and just let the player manage the companion inventory directly.  Maybe you couldn't do that when you made the module but now you can and there's no practical difference besides convenience (managing directly being more convenient) since you seem to be fine with allowing us to buy companions armor.

 

 

Bort - The Witch is the only person who will purchase undead parts. She should buy them without issue to the player. I've never had an issue selling the undead parts to the Witch. Curious.
 

Bort - I don't believe 'appraise' was a feature in NWN original release.

 

Bort - [SPOILER] You identify the ring by using the feat "Identify," or by giving it to Lynn. The Ring of Light is more or less an Easter Egg. There are actually two instances of it in the game. The other instance is in the village, which you find out about if you create a Ranger class and 'talk' to the various farm animals in the game, or if you examine the farm animals (as any class) and read their descriptions to tie it all together. It's a more difficult Easter Egg to find than the Spider Cave, but more accessible early on if you're very observant. The Spider Cave is most certainly nonsense. Most players, I had experienced, don't put up with it long enough to find the ring. I admit, it's completely nonsensical, but you are rewarded for exploration in the end. No where does the module suggest going into the Webbed Cave is a good idea, or relevant to story progression. I wanted to reward players for sticking it through, as it's something many players won't do. The Lynn aspect of the above note is again, very curious.

 

1. There was no mechanical issue selling the parts to the witch, I just figured it might be a better idea to purify the desecrated remains of villaged loved ones rather than give them to a crazy mage to eat in a stew.

 

2. It wasn't, it was added in SoU (along with henchmen inventory and other things).

 

3. The main problem with the spiders is that you have no reason to think "Huh, maybe I need to run past the spiders trying to eat my face rather than kill them like everything else in the module to find a chest with a ring in it."  I did it because I'm trying out everything for beta-testing but I expected to find nothing, I did it purely out of thoroughness when it seemed clear the spiders were infinite and would basically respawn instantly too.

 

Overall, yes, I think the module held up quite well for its age and was better than most modules I've played.

[BortSonofBort]

I would just try to make a note of that as I expect many people would AVOID looting stuff out of principle -- they don't want to just steal from the orchid owner, for example. Or even make an NPC say "You're helping the village out? Take anything you need." It's mainly a problem since it seems to be assumed that the player will loot that sort of stuff so players who DON'T are at a major disadvantage.


Hell, I only looted it to test it since this is beta feedback.

You're 100% correct. I'll make a point of the NPCs referencing that for the sake of 'saving the village,' they encourage you to loot from them. Great idea.

 

Oh, I got the general idea, I just liked Lynn's personality better and figured as a cleric she'd still be reasonable in a fight.


I think the biggest problem is that there is really *zero* reason to pick Lynn, mechanics-wise. Yes, she has slight healing, but the fighter is going to butcher stuff and you have plenty of healing anyway. Would rather have a second fighter AS a fighter. Going to save more on healing costs by just killing stuff faster than she'd ever make up.

If you swapped her to something like 14 strength starting and let her wear some armor she'd still be WEAKER than the fighter but it's now "better offense versus minor healing" (she likes to use Turn Undead versus single undead...doesn't really help when you're facing 50 of them and she has six uses).

Again, you're 100% correct. I'll look at raising Lynn's stats/buffs.

 

Yes, I could sell crossbows but not the melee weapons at the weapon rack.

Definitely need to fix that then.

 

I never actually gave Lynn better armor since her option is to adjust everything BUT her armor so I figured she WOULDN'T equip it.

I'll examine this.
 

Honestly, I think you might be better off biting the bullet and just let the player manage the companion inventory directly. Maybe you couldn't do that when you made the module but now you can and there's no practical difference besides convenience (managing directly being more convenient) since you seem to be fine with allowing us to buy companions armor.

You might be right. Another concept I'll explore, for sure.

 

1. There was no mechanical issue selling the parts to the witch, I just figured it might be a better idea to purify the desecrated remains of villaged loved ones rather than give them to a crazy mage to eat in a stew.


2. It wasn't, it was added in SoU (along with henchmen inventory and other things).

3. The main problem with the spiders is that you have no reason to think "Huh, maybe I need to run past the spiders trying to eat my face rather than kill them like everything else in the module to find a chest with a ring in it." I did it because I'm trying out everything for beta-testing but I expected to find nothing, I did it purely out of thoroughness when it seemed clear the spiders were infinite and would basically respawn instantly too.

1. You're not the first player to suggest this. I'll have other merchants tell the PCs that no cleansing is necessary.

2. Aha! I know nothing of how awareness functions in NWN currently. If it's a quick edit, I think it would be an amazing feature to add considering how the player generates coins in the module from non-typical items.

3. I think you're dead on. You do have no reason to think that you should try to fight through the spiders to find anything, which I think is originally part of the reason I threw that curve ball in there for the player. I wanted to reward those more adventurous of the bunch. Maybe I can make a slight mention of 'something' in the Webbed Cave. In an earlier build, I'm talking 2003, once you failed at trying to steal items from Willy three times, he would ask you to go to the Webbed Cave and bring him back 50 scales or so to ease his being upset at you for trying to steal from him, then lowering his prices back to normal. I might have to explore going back to that principle, if but to flesh out the Spider Cave some.

 

Overall, yes, I think the module held up quite well for its age and was better than most modules I've played.

Love it. And many thanks. I recall some players in 2003 were utterly baffled that I used no custom hak packs, but I was determined not to. I believed very strongly that while custom hak packs were very cool (and they certainly are), they are not necessary to create an enjoyable adventure if you try to use the default content creatively. I spent more time on this module when I originally designed it trying to cram as much detail as I could into a 3 to 5-hour experience (with lighting, music usage, visual and sound effects), as well as in the past few months ironing out old story details, grammar, spelling, and overall polish than I care to admit to most people. I'm so pleased you enjoyed yourself.

As I've mentioned, Small Village Woes was designed to scale outward. Had I more time, I could implement relatively easily different character class skills into the module (persuasion, etc.). I even left access to branching out to new areas in the native design of the Small Village. The barricaded exits, for instance, would allow for new chapters in different regions of the SVW world, as well as the locked homes in the village center becoming hubs for new quests and the like. Although I don't have the kind of time in my life to devote to this module's further development, who knows what might happen in the future, I suppose...

As it is, I'm happy to currently have enough time to try hammering out the remaining bugs and major hiccups.

[BortSonofBort]

Also, MagicalMaster, let me add that if you have any more feedback on the various pricing of merchant goods, I'm all ears. I think a review of their pricing scale could really benefit the module. In these latest revisions of the past couple of months, I've added more wealth overall to the world, so I imagine that further retooling of the merchant prices could stand to be reviewed. If you have any more thoughts on this, in general or specific, I'd be happy to hear them.

[MagicalMaster]

2. Aha! I know nothing of how awareness functions in NWN currently. If it's a quick edit, I think it would be an amazing feature to add considering how the player generates coins in the module from non-typical items.

 

Appraise only fires by default when enabled on a merchant.  Say you have an appraise skill of 5 and the merchant has 0.  By default the merchant buys something for 50g and sells it for 200g (making these numbers up to show the idea).  We'll also assume every 1 difference is a 1% difference in price.  There's an opposed roll (d10) and the player gets a 3 while the merchant gets a 10.  That's 8 vs 10, so 2% in favor of the merchant.

So now the merchant buys that item for 49g and sells it for 204g.

 

In your case, I think the simplest way to do it would be to simply call a function named something like "ApplyAppraiseSkill" or something that looked at the PC's appraise and adjusted things appropriately -- perhaps something like decreasing cost by multiplicative 1% and increasing sell by 1% multiplicative.

 

So say the PC has 6 appraise.  When he says he wants to buy the longbow (175g), the script does the stuff it does now plus calls that function so that 175 becomes 175/1.06 = 165g.  When he wants to sell the longbow (90g) the same thing happens in reverse -- 90 * 1.06 = 95g.  Just need a library with the function so you can call that function in each script -- should literally only need to adjust 1 line of code per buy/sell script.

 

3. I think you're dead on. You do have no reason to think that you should try to fight through the spiders to find anything, which I think is originally part of the reason I threw that curve ball in there for the player. I wanted to reward those more adventurous of the bunch. Maybe I can make a slight mention of 'something' in the Webbed Cave. In an earlier build, I'm talking 2003, once you failed at trying to steal items from Willy three times, he would ask you to go to the Webbed Cave and bring him back 50 scales or so to ease his being upset at you for trying to steal from him, then lowering his prices back to normal. I might have to explore going back to that principle, if but to flesh out the Spider Cave some.

 

You could simply make it a short cave with a bunch of triggers so that you'd have to fight like 30 spiders as you go through but they don't just instantly respawn indefinitely.  The main problem is that it goes against what the PC has been taught for the rest of the module which is "kill the stuff attacking you."  The collision detection in NWN can also make it so you get "stuck" unable to go past the spiders -- I managed because I was spamming scrolls of Call Lightning which would often wipe out an entire group of spiders.

 

I spent more time on this module when I originally designed it trying to cram as much detail as I could into a 3 to 5-hour experience (with lighting, music usage, visual and sound effects), as well as in the past few months ironing out old story details, grammar, spelling, and overall polish than I care to admit to most people. I'm so pleased you enjoyed yourself.

 

It shows.

 

Something I managed mentioned yet is the general dialogue system, which I generally did like.  Reminds me of the dialogue wheel in ME 1/2/3 and DA2.  I've definitely been frustrated when my only dialogue option is to say something ridiculous and you think "I wouldn't phrase it that way at all!"

 

Also, MagicalMaster, let me add that if you have any more feedback on the various pricing of merchant goods, I'm all ears. I think a review of their pricing scale could really benefit the module. In these latest revisions of the past couple of months, I've added more wealth overall to the world, so I imagine that further retooling of the merchant prices could stand to be reviewed. If you have any more thoughts on this, in general or specific, I'd be happy to hear them.

 

Hard to say, for a few reasons.

 

1, I had tons and tons of undead parts to sell.  That definitely affects things.

 

2, I didn't sell the ring for 2.5k.  That DEFINITELY affects things.

 

3, I bought hundreds of scrolls because mob HP was so high -- if mob HP weren't as crazy in some cases then obviously less scrolls would be needed which means less gold would be be needed.

 

So all in all it probably makes sense to generally balance the gold last because how much gold we need for healing/scrolls/whatever highly depends on how much damage we take and how many offensive scrolls we need.  I didn't even ever bother with Stoneskin scrolls or anything.

[Shadooow]

I checked the module for the henchman issues as Iam recently working with henchmen AI.

 

There is some ancient AI rework by Pausanians which, judge on the MM comments, is way worse than vanilla default AI.

 

I would tried to remove these scripts:

nw_ch_ac1

nw_ch_ac2

nw_ch_ac3

nw_ch_ac4

nw_ch_ac5

nw_ch_ac6

nw_ch_ac7

nw_ch_ac8

nw_ch_ac9

nw_ch_acb

nw_ch_gomelee

nw_ch_goranged

 

this will use a default AI for henchmans, or you can try to use TonyK henchman AI but that requires more work

[BortSonofBort]

Appraise only fires by default when enabled on a merchant.  Say you have an appraise skill of 5 and the merchant has 0.  By default the merchant buys something for 50g and sells it for 200g (making these numbers up to show the idea).  We'll also assume every 1 difference is a 1% difference in price.  There's an opposed roll (d10) and the player gets a 3 while the merchant gets a 10.  That's 8 vs 10, so 2% in favor of the merchant.

So now the merchant buys that item for 49g and sells it for 204g.

 

In your case, I think the simplest way to do it would be to simply call a function named something like "ApplyAppraiseSkill" or something that looked at the PC's appraise and adjusted things appropriately -- perhaps something like decreasing cost by multiplicative 1% and increasing sell by 1% multiplicative.

 

So say the PC has 6 appraise.  When he says he wants to buy the longbow (175g), the script does the stuff it does now plus calls that function so that 175 becomes 175/1.06 = 165g.  When he wants to sell the longbow (90g) the same thing happens in reverse -- 90 * 1.06 = 95g.  Just need a library with the function so you can call that function in each script -- should literally only need to adjust 1 line of code per buy/sell script.

 

I'll have to circle back to you about this. Not surprisingly, there are a lot (a lot) of buy/sell scripts in use. If this added piece of code turns out to be a simple cut and paste, we might be in business.

 

You could simply make it a short cave with a bunch of triggers so that you'd have to fight like 30 spiders as you go through but they don't just instantly respawn indefinitely.  The main problem is that it goes against what the PC has been taught for the rest of the module which is "kill the stuff attacking you."  The collision detection in NWN can also make it so you get "stuck" unable to go past the spiders -- I managed because I was spamming scrolls of Call Lightning which would often wipe out an entire group of spiders.

 

That's a fine practical point about the expectations that the module sets for the PC, and how that affects the experience of the Webbed Cavern. Frankly, the chances are greater I'm just going to drop the Webbed Cavern when I release a final build of this latest update. The Cave area as a whole has absolutely nothing to do with the story, and as you've pointed out, acts a-typically of the mechanical expectations set by the module overall.

 

I've definitely been frustrated when my only dialogue option is to say something ridiculous and you think "I wouldn't phrase it that way at all!"

 

Amen.

 

Hard to say, for a few reasons.

 

1, I had tons and tons of undead parts to sell.  That definitely affects things.

 

2, I didn't sell the ring for 2.5k.  That DEFINITELY affects things.

 

3, I bought hundreds of scrolls because mob HP was so high -- if mob HP weren't as crazy in some cases then obviously less scrolls would be needed which means less gold would be be needed.

 

So all in all it probably makes sense to generally balance the gold last because how much gold we need for healing/scrolls/whatever highly depends on how much damage we take and how many offensive scrolls we need.  I didn't even ever bother with Stoneskin scrolls or anything.

 

1. Which isn't always the case. I've seen some players loot the Zombies a couple of times, not know what to do with the parts, and then simply stop looting them. I actually enjoy rewarding the looting hoarder, as it were.

 

2. Yup. Again, chances are I'm going to blow-up the Webbed Cavern for a few reasons.

 

3. I'll give a look at mob HP, particularly the Br'ei Soldiers and the Act 3 Hook Demons.

 

Coming back to the gold concept once the module has been balanced better is a terrific notion.

[BortSonofBort]

I checked the module for the henchman issues as Iam recently working with henchmen AI.

 

There is some ancient AI rework by Pausanians which, judge on the MM comments, is way worse than vanilla default AI.

 

I would tried to remove these scripts:

nw_ch_ac1

nw_ch_ac2

nw_ch_ac3

nw_ch_ac4

nw_ch_ac5

nw_ch_ac6

nw_ch_ac7

nw_ch_ac8

nw_ch_ac9

nw_ch_acb

nw_ch_gomelee

nw_ch_goranged

 

this will use a default AI for henchmans, or you can try to use TonyK henchman AI but that requires more work

 

I'll experiment with removing some of the scripts that you think highlight where these issues are coming from and see if it positively impacts the henchmen AI, Shadooow.

 

Thanks!

[MagicalMaster]

I'll have to circle back to you about this. Not surprisingly, there are a lot (a lot) of buy/sell scripts in use. If this added piece of code turns out to be a simple cut and paste, we might be in business.

 

It should be.  Basically, instead of

 

GiveGoldToPlayer(5, oPC);

 

you'd have

 

GiveGoldToPlayer(ApplyAppraiseSkill(5), oPC);

 

3. I'll give a look at mob HP, particularly the Br'ei Soldiers and the Act 3 Hook Demons.

 

Coming back to the gold concept once the module has been balanced better is a terrific notion.

 

Interestingly enough, it was mainly the sheer amount of zombies and the HP of the Br'ei BOSSES that were the main problem prior to the demons.

 

And yeah -- a fighter might be swimming in gold because he has high AC/damage and needs little healing while a sorcerer may be spending all their gold on Magic Missile scrolls.  Conversely, a sorcerer may be able to use AoE scrolls to wipe out groups of enemies that otherwise force the fighter to chug healing potions.  Very balance/item/class dependent.

[BortSonofBort]

It should be.  Basically, instead of

 

GiveGoldToPlayer(5, oPC);

 

you'd have

 

GiveGoldToPlayer(ApplyAppraiseSkill(5), oPC);

 

WIll look into this. Thanks, MM.

 

Interestingly enough, it was mainly the sheer amount of zombies and the HP of the Br'ei BOSSES that were the main problem prior to the demons.

 

I bumped the Br'ei Bosses HP right before release of this latest BETA build. Good to know. Also, I'm going to extend the length of the zombie encounter respawn refresh triggers.

 

Good stuff!

[MagicalMaster]

WIll look into this. Thanks, MM.

Keep in mind that the ApplyAppraiseSkill is a function you'd write but it probably can be done in 10 lines or less.

 

I bumped the Br'ei Bosses HP right before release of this latest BETA build. Good to know. Also, I'm going to extend the length of the zombie encounter respawn refresh triggers.

Why even have the zombies respawn in the crypt?  What does that add?  If people want to grind XP there's zombies in the forest.

[BortSonofBort]

Why even have the zombies respawn in the crypt?  What does that add?  If people want to grind XP there's zombies in the forest.

 

The whole module is coded to work as a semi-persistent world. Everything refreshes. Quest variables are often set on a PC by obtaining a radius around the NPC providing the quest variable. Back in the day, more time than I care to admit (part 2) was invested in making sure the game could play as a hosted semi-persistant world. In 2014, there is clearly much less demand for that sort of thing. But the whole module, every item, every instance of a character, every piece of action should entirely respawn itself over enough time. I'd rather keep that technique going than scrap it at this stage.

[BortSonofBort]

I've written down all of the above notes/feedback since the release. Tomorrow I'm going to see how much I stamp out in a good lengthy sitting. Once I'm done (whether that is tomorrow or later), I'll be sure to journal what edits I've made so there's a reference point. By the time this process is completed (and potentially more feedback given, and more edits made) I'll undoubtedly release this next update as Small Village Woes 1.30.

 

Exciting!

[MagicalMaster]

In 2014, there is clearly much less demand for that sort of thing. But the whole module, every item, every instance of a character, every piece of action should entirely respawn itself over enough time. I'd rather keep that technique going than scrap it at this stage.

 

There's still demand for fully persistent worlds, but yeah.

 

That said, fighting through the same zombies multiple times in the crypts is annoying, doubly so since to sell their "loot" you need to find the Witch.  But hopefully extending the cooldown helps.

[Shadooow]

One important suggestion for you Bort.

 

Don't listen MM too much. He got a point in most of his finding, but he is greatly obsessed with game balance.

 

In my opinion you won't be ever able to balance this to be equal for all classes and definitely not balance it the way to satisfy the MM .

[MagicalMaster]

If I was attempting to balance this properly I assure you the feedback would have been far more extensive.  All I've done is note the most glaring issues -- a small module like this doesn't need amazing balance.  Big difference between "reasonably playable" and "balanced" and I'm only concerned about the former here.

[BortSonofBort]

I think everyone is coming to the module with the right spirit--to polish it for what it is. To provide feedback for quicker fixes that will add to a final(ish) product. MM in particular has been very (very) helpful in this regard. I honestly can't thank everybody enough.

My goal has been to clean it up as much as possible without tearing out the guts of the thing, and I think we're being successful in that.

[Bort_Son_of_Bort]

Small Village Woes v1.30 Update [SPOILERS BELOW]:

 

I definitely underestimated the time needs for the amount of great feedback that's been given to me thus far. But I'm happy to report definite progress has been made.

 

Module Lighting - I worked through every area doing a prognosis of the current lighting schemes. Notwithstanding the fact that the module is intended to be very dark, I tried my best to find a balance.

a.) Where there are no light objects placed, I did my best to add highlights to the area properties throughout. Doors have added highlights on them to make them 'stand out' in the visually dark palette.

b.) Overall, I've spread out the effect of a lit area so that it covers more blocks of space. Not terribly more, but a definite change.

c.) Areas that have been VERY dark, like the Burial Chambers, Lenny's Lodge, Farmer Fred's Manor, and sections of the Small Village and The Forest now have added light sources and highlights.
d.) I've added outside torches to the Orchard House and Church.

 

Module Entry Area - I've gotten some great feedback about some things that are lacking here.

 

a.) I've added an OnEntry script that causes Elf and Half-Elf races to appear "knocked down" at the beginning of the module to feign sleeping, since they're immune to the physical sleeping effect of laying down on the ground.

b.) I've made two of the entrance guards able to assist in defending the PC from the Wolf Pack encounter if they are close enough.

 

Looting - Something had to be done about looting objects found in buildings or outside when an NPC is standing watch.

 

a.) I've added scripts on an object use/opening that will cause a nearby NPC to remark about the looting attempt, or a parenthetical observation that provides sufficient reasoning for the PC being able to loot the object if he/she wants to. Some of these NPC driven notes also take the form of statements within a conversation. At times, there are variations of a response depending on if the PC unlocks/opens an object, or bashes it open.

Misc. Edits - Some added fixes.

 

a.) I've removed the chests in the Witch's Den and put them at the farthest end of the Burial Chamber in Act 1. This not only solved the looting issue in a merchant's quarters, but gave the player some much needed buffs/health items halfway through the Burial Chambers quest.

b.) "Bag of Holding" is now (tongue-in-cheek) "Bag of Carrying."
c.) Various Billy word choices fixed in the merchant menu.

 

This is where I'm at so far. I still have two pages worth of feedback to work through.

[BortSonofBort]

Small Village Woes v1.30 Update | 6.30.04 [SPOILERS BELOW]:

 

Most of my time today was spent focusing on the various merchants, but some other edits were made, too.

 

Merchant Fixes - Lots.

 

a.) Fixed up some text-related dialogue irregularities in the merchant conversations.

b.) Added bullets and slings to Brother Billy's merchant options.

c.) Doubled the amount of ammunition/throwing weapon stacks for their current value.

d.) Fixed Witch 'information' dialogue options.

e.) Fixed Willy token error.

f.) Willy's weapon, armor, kit, and misc. goods rack now informs PCs about undead-items.

g.) Bastard Sword and Katana are the same price now.

h.) Tower Shield now listed at proper weight.

 

 

REQUEST FOR HELP - In trying to fix the merchant system's affiliation discount, I did some play-testing. It would appear via the merchant hide/reveal scripts I'm using to show players who are the proper affiliation to a specific merchant their discounted item price, that I'm possibly using the wrong check function.

Currently, the script uses GetLevelByClass to check if the PC is either a Cleric, Paladin, Wizard, or Sorcerer. What I've discovered is that when a PC of these class types is beyond Level 1, the class check doesn't work. Level 1 PCs of these class types allow the script to function as intended.

 

To solve this issue, I wonder if I should be using GetClassByPosition?

 

Let me know what you think.

 

Thanks!

[MagicalMaster]

Link the script, please.

 

I'm *guessing* you have

 

if (GetLevelByClass(CLERIC) == 1)  blah blah

 

when you just neeed

 

if (GetLevelByClass(CLERIC)) blah blah

 

Obviously that's not the actual code but that would match your problem.

[BortSonofBort]

As indicated below, I don't currently have the script looking for a set Class Level in the "Text Appears When..." field. My thinking was the script would simply identify any level of the class and return TRUE when needed, which is what I'm looking to do with the script.

 

Thanks for the help clearing this up!

 

Discount Price Script:

#include "nw_i0_tool"

int nWizard = CLASS_TYPE_WIZARD;
int nSorcerer = CLASS_TYPE_SORCERER;

int StartingConditional()
{
object oPC = GetPCSpeaker();
if(GetGold(oPC) > 24 && (GetLevelByClass(nWizard, oPC) || GetLevelByClass(nSorcerer, oPC)))

return TRUE;

return FALSE;
}

Full Price Script:

#include "nw_i0_tool"

int nWizard = CLASS_TYPE_WIZARD;
int nSorcerer = CLASS_TYPE_SORCERER;

int StartingConditional()
{
object oPC = GetPCSpeaker();
if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) == TRUE || GetLevelByClass(nSorcerer, oPC) == TRUE)

return FALSE;

return TRUE;
}

[MagicalMaster]

What exactly is the behavior that you're seeing?

 

Also, try changing

 

if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) == TRUE || GetLevelByClass(nSorcerer, oPC) == TRUE)

 

to

 

if(GetGold(oPC) < 50 || GetLevelByClass(nWizard, oPC) || GetLevelByClass(nSorcerer, oPC))

 

and see if that helps.

[BortSonofBort]

What I'm seeing is when a PC of these class types is beyond Level 1, the class check doesn't work, and all dialogue-based purchase options are visible depending on if they do or don't have enough money to purchase the item (which you experienced, I believe MM, in your play-through of the module). If a PC of these class types is level 1, the scripts function as intended.

For all non-affiliated PCs of all other class types, the scripts function as intended.

 

(I have not tried your above suggestion yet.)

[MagicalMaster]

Did a quick test during lunch break -- TRUE is read as 1 only.  In the test I got the following...

 

3 != TRUE

1 == TRUE

0 != TRUE

 

The last result is obvious but the first is not.  So the change I made above will fix your problem, I think.