With that stuff - it's "worth the price of admission" - which is a line often used when deciding to date someone. But I think it applies well for friends. For me...in this game...she's worth it. She does care. She's tough as nails and certainly snobbish but once you're her buddy, it's always sent off in another direction. She also is amazingly compassionate. She tells that one guy to "eff off" when he was being homophobic about Dorian -- and they don't really get a long. She is one of the ONLY companions that really openly grieves when you find the horror shed in Redcliffe(Oculara). Which for me, was very telling about her character(mostly because I thought that was the absolutely most grotesque thing in the whole game).
I can see her rubbing some people the wrong way, and it's just not worth it. For me it is.
She's the only one my Inquisitor did not wind up registering as friends with, which should say something. Though Keep wouldn't let me say that without a world state that wouldn't be valid, so officially, that changed. I hardly used her past a certain point since I use two mages in my party and I love Dorian, so he and Solas were it.
She might care at times, but ultimately, it's all about her. After her quest, I just felt utterly used and disgusted.
edit: I'm not saying that I dislike characters that I find personally to be internally polarizing. Sera pulls me in two directions, for instance, but ultimately, I am more on the love side with her.