I respect the time you took to lay all this out, and I was looking for something like this because I had a bit of a dilemna: Attack or Crit. damage? Now I'm more confused. According to your numbers, if my weapon is a base 150 and the opponents armor is 50:
With attack%, if I put, say, 8 material to get a +14% attack bonus, then after enemy armor is factored in, I should be doing 114 dam, and about 160 if I pull a Crit.
Now with Crit Dam%, if I put 8 equivalent tier material I get 24% extra Crit Dam, on top of the 40% default, factored in before armor reduction. That gives me about 246 - after armor reduction 196.
Yet you put Crit Dam down near the bottom of crafting priorities for a DPS char., even under Cunning which gives you no Damage modifier at all.
I guess perhaps for a Reaver, even when geared towards Crits, who doesn't have a guaranteed crit chance attack might be preferable over the long haul. But for a rogue who has a lot of guaranteed crits, and Armor Penetration built in on top of that, I don't see how Crit Dam isn't far superior to attack. But I also realize I'm probably missing some obvious detail here.